Move configurations to pyproject.toml, use ruff#754
Merged
lovelydinosaur merged 9 commits intoencode:masterfrom Jul 13, 2023
Merged
Move configurations to pyproject.toml, use ruff#754lovelydinosaur merged 9 commits intoencode:masterfrom
pyproject.toml, use ruff#754lovelydinosaur merged 9 commits intoencode:masterfrom
Conversation
zanieb
reviewed
Jul 11, 2023
zanieb
reviewed
Jul 11, 2023
zanieb
reviewed
Jul 11, 2023
Contributor
Author
|
How did I break the |
zanieb
reviewed
Jul 12, 2023
Co-authored-by: Zanie <contact@zanie.dev>
Kludex
reviewed
Jul 12, 2023
Contributor
Kludex
left a comment
There was a problem hiding this comment.
We also removed autoflake in other encode projects, since it becomes redundant as well.
zanieb
reviewed
Jul 12, 2023
zanieb
approved these changes
Jul 12, 2023
Contributor
Author
|
@tomchristie , did we break anything? Why does this test fail while the branch is up to date? |
Contributor
Which test? |
Contributor
It was a previous issue from click. Now it's solved. |
Contributor
Author
|
@tomchristie check this job. Related to #755 |
lovelydinosaur
approved these changes
Jul 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #751
Refs: encode/httpx#2648 encode/httpx#2680
Let's move all of our configurations to the
pyproject.tomlfile so that we have a single file for our project metadata. I also added ruff as a dependency becauseflake8does not supportpyproject.toml.