Move setuptools to testing requirements#9818
Merged
browniebroke merged 1 commit intoencode:mainfrom Nov 4, 2025
Merged
Conversation
f55e8b9 to
1a88ae5
Compare
It was defined in `testenv.deps` for tox, making it a literal testing requirement. The version requirement is copied from `pyproject.toml`.
1a88ae5 to
c096d18
Compare
auvipy
approved these changes
Nov 2, 2025
Member
|
Do we need it at all? I would have thought we could remove it entirely but maybe it's needed by one of our deps? |
Member
|
Tests seems to pass without it, so I'm pretty sure we no longer meed it (I'm assuming since #9056). It's also added to GitHub actions here: Can we remove it from all these places, please? |
Contributor
Author
It causes 61 tests to skip tho. I'll revisit this when I have the time, probably on the weekend. |
Member
Oh I missed that. I thought they were skipped purely because of the other missing dependency. |
browniebroke
added a commit
that referenced
this pull request
Feb 7, 2026
* Bump the optional group with 4 updates Updates the requirements on [coreapi](https://github.com/core-api/python-client), [django-guardian](https://github.com/django-guardian/django-guardian), [pygments](https://github.com/pygments/pygments) and [pyyaml](https://github.com/yaml/pyyaml) to permit the latest version. Updates `coreapi` from 2.3.1 to 2.3.3 - [Commits](core-api/python-client@2.3.1...2.3.3) Updates `django-guardian` to 3.2.0 - [Release notes](https://github.com/django-guardian/django-guardian/releases) - [Commits](django-guardian/django-guardian@v2.4.0...3.2.0) Updates `pygments` to 2.19.2 - [Release notes](https://github.com/pygments/pygments/releases) - [Changelog](https://github.com/pygments/pygments/blob/master/CHANGES) - [Commits](pygments/pygments@2.17.0...2.19.2) Updates `pyyaml` to 6.0.3 - [Release notes](https://github.com/yaml/pyyaml/releases) - [Changelog](https://github.com/yaml/pyyaml/blob/6.0.3/CHANGES) - [Commits](yaml/pyyaml@5.3.1...6.0.3) --- updated-dependencies: - dependency-name: coreapi dependency-version: 2.3.3 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: optional - dependency-name: django-guardian dependency-version: 3.2.0 dependency-type: direct:development dependency-group: optional - dependency-name: pygments dependency-version: 2.19.2 dependency-type: direct:development dependency-group: optional - dependency-name: pyyaml dependency-version: 6.0.3 dependency-type: direct:development dependency-group: optional ... Signed-off-by: dependabot[bot] <support@github.com> * Add back setuptools Was added to testing requirements in #9818 But that was lost in: #9842 Moving to optional dep group as it's only needed for coreapi --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Asif Saif Uddin {"Auvi":"অভি"} <auvipy@gmail.com> Co-authored-by: Bruno Alla <alla.brunoo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was defined in
testenv.depsfor tox, making it a literal testing requirement. The version requirement is copied frompyproject.toml.This change helps with the local testing, in a similar way to #9817 does. Because
setuptoolsdependency was only defined for tox, the recommended testing method in https://www.django-rest-framework.org/community/contributing/#testingwere skipping coreapi related tests.