Replace update-tags (which has no effect) with update#22
Replace update-tags (which has no effect) with update#22mymindstorm merged 1 commit intoemscripten-core:masterfrom kofigumbs:master
Conversation
|
I confirm this fixes the problem for me as well. Thanks! Using your fork in the meantime... |
|
I apologize for missing this, I've been very busy. It does seem that |
Please be aware that @kofigumbs 's fork has not updated dist/index.js, meaning that his changes are not actually being executed when using the action. |
|
Thanks for the quick turn around!
Oh, strange that it worked then. I'll switch back to your repo to be on the safe side, thank you for the warning. |
|
No problem. A tag for v11 has been created. |
I encountered the following error in my action whenever I set an explicit version:
My workflow config
Changing
emsdk update-tagtoemsdk updatefixed it for me, but I'm not 100% sure if that's the right solution. It does seem likeupdate-tagsis effectively gone though: emscripten-core/emsdk#738.If this switch to
updateis the way you want to go, I'd be happy to do the work to get this PR merge-ready. I only had to change the implementation to workaround the issue, but I imagine we'd at least want to update the docs too. One open question is whether changing the name in the action input would cause any compatibility concerns.