Conversation
Collaborator
Author
|
This change builds on the back of the #732 |
9ce5492 to
a98ec8a
Compare
Member
|
Hmm, but with this one doesn't know what tot will get installed. So one can't edit the txt file. But I guess we don't want people doing that anymore now that that PR landed that you quoted, is that the idea? |
Collaborator
Author
|
Exactly, the text file doesn't really serve much purpose once you can just install any SHA you like directly from the command line. Also, was editing this text file by hand ever documents or recommended anywhere? |
Collaborator
Author
|
I always found it a little odd that |
a98ec8a to
4f8939b
Compare
Its not really very useful to cache the tot release in a local text file. Instead just fetch the revsion each time `install tot` is run. This avoids folks accidentally installing "old" tot releases. Also, make the output a little less chatty when looking up tot version.
4f8939b to
10d2a5e
Compare
kripken
approved these changes
Mar 5, 2021
akoeplinger
pushed a commit
to akoeplinger/emsdk
that referenced
this pull request
Dec 13, 2024
…scripten-core#738) [main] Update dependencies from dotnet/cpython, dotnet/emscripten
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Its not really very useful to cache the tot release in a local text
file. Instead just fetch the revsion each time
install totis run.This avoids folks accidentally installing "old" tot releases.
Also, make the output a little less chatty when looking up tot version.