Merged
Conversation
ad539c1 to
7a3dfdf
Compare
7a3dfdf to
f5c09d7
Compare
embedded mode as been the default since #472 and I included `--no-embedded` as an option during the interim time, but to simply the code and avoid have two modes of operation I think its safe to now remove the non-embedded mode.
f5c09d7 to
5cd7a5b
Compare
kripken
approved these changes
Jul 20, 2020
Member
kripken
left a comment
There was a problem hiding this comment.
Was embedded already the default, so that this doesn't change that, and the only possible breakage is people passing in --embedded / --no-embedded? lgtm if so.
Collaborator
Author
|
Yup.. its been the default for a while now. |
vargaz
pushed a commit
to vargaz/emsdk
that referenced
this pull request
Nov 22, 2023
…m>=net8.0 (emscripten-core#510) Fixes: `/root/helix/work/workitem/e/dotnet-latest/sdk-manifests/9.0.100-alpha.1/microsoft.net.workload.emscripten.net8/WorkloadManifest.targets(4,5): warning MSB4011: "/root/helix/work/workitem/e/dotnet-latest/packs/Microsoft.NET.Runtime.Emscripten.3.1.34.Node.linux-x64/9.0.0-alpha.1.23469.6/Sdk/Sdk.props" cannot be imported again. It was already imported at "/root/helix/work/workitem/e/dotnet-latest/sdk-manifests/9.0.100-alpha.1/microsoft.net.workload.emscripten.current/WorkloadManifest.targets (23,5)". This is most likely a build authoring error. This subsequent import will be ignored. `
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See emscripten-core/emscripten#9543