Conversation
|
cc @trzecieu |
|
|
||
| def hack_emsdk(marker, replacement): | ||
| src = open('emsdk').read() | ||
| src = open('emsdk.py').read() |
There was a problem hiding this comment.
why are the tests changed? none of the old usages are tested, so we lost coverage for the old ./emsdk use pattern, which is what users are doing. best to test both (the official/intended, and also I assume some people will call the new emsdk.py directly because they find it).
There was a problem hiding this comment.
This test in particular is hacking the python source itself, so it needs to change.
| check_call('python2 ./emsdk install latest-upstream') | ||
| check_call('./emsdk activate latest-upstream') | ||
| check_call('python2 ./emsdk.py install latest-upstream') | ||
| check_call('python3 ./emsdk.py activate latest-upstream') |
There was a problem hiding this comment.
In addition I'd keep the old check check_call('./emsdk activate latest-upstream')
|
Looks good, indeed it will be much cleaner. In the current form this script will hit issue addressed by #275. That is in case of pyenv, |
This change moves the python code for emsdk into a file ending in .py. This script is then run via emsdk.bat on windows or emsdk (a shell script) on non-windows. This avoid the #!/bin/sh at the top of the python script and the "exec" hack on the first line that re-runs it under python. Hopefully this preserves the intent of #273 without jumping through so many hoops.
This change moves the python code for emsdk into a file ending in .py.
This script is then run via emsdk.bat on windows or emsdk (a shell
script) on non-windows.
This avoid the #!/bin/sh at the top of the python script and the "exec"
hack on the first line that re-runs it under python. Hopefully this
preserves the intent of #273 without jumping through so many hoops.