Change ino_t/off_t to 64-bits#8467
Conversation
|
@kripken Hmm, any idea how to force the "other" tests to use the wasm backend? On my dev machine |
| run(['-Oz'], 0, [], [], 54, 0, 1, 1) # noqa | ||
| else: | ||
| run([], 20, ['abort'], ['waka'], 22712, 20, 14, 27) # noqa | ||
| run([], 21, ['abort'], ['waka'], 22712, 22, 15, 30) # noqa |
There was a problem hiding this comment.
it's very odd this would change, as the program doesn't use syscalls. do you know what's going on here?
There was a problem hiding this comment.
Yes I thought that was odd too, let me look a bit more closely
There was a problem hiding this comment.
The extra exports/imports are due to new dyncalls using 64bit ints.
|
To use the wasm backend, you need to use a build of llvm with it installed. One way is that on linux you can use |
tests/test_other.py
Outdated
| run(['-O2'], 15, [], ['waka'], 10183, 15, 14, 28) # noqa | ||
| run(['-O3'], 6, [], [], 2353, 9, 2, 15) # noqa; in -O3, -Os and -Oz we metadce | ||
| run(['-Os'], 6, [], [], 2310, 9, 2, 17) # noqa | ||
| run(['-Oz'], 6, [], [], 2272, 9, 2, 16) # noqa |
There was a problem hiding this comment.
Nothing to do with this CL, but when changes break the metadce tests (which they often do) its quite hard to see whats changing. Perhaps we should generate an "out" file containing all of the imports and exports by name rather than just number of them?
There was a problem hiding this comment.
In higher optimization levels those import names are minified, though, so it may not be feasible to have useful names for them.
|
Just FYI this should be ready to go |
|
lgtm (i'll re-run the failing chrome tests). |
|
@sbc100 note that I changed the version number but haven't changed them in the other project components. is that alright? |
I'm not sure I understand the question. What other components? |
|
lgtm too, but we should update the changelog file as well, I'll do that after I merge. By version number do you mean the emscripten version in the fastcomp and fastcomp-clang repos? We'll need to update them too, but I can do that right after I merge this PR. |
Related to emscripten-core#7649 (point 5) and subset of emscripten-core#7799 * Update python.bc * Update output wasm sizes * Update wasm backend tests
This reverts commit 38b0ea3.
This reverts commit 38b0ea3.
Related to emscripten-core#7649 (point 5) and subset of emscripten-core#7799 * Update python.bc * Update output wasm sizes * Update wasm backend tests
Related to #7649 (point 5) and subset of #7799
Not sure exactly how to change the Emscripten version number.