Remove deprecated function Pointer_stringify() #8011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
Feb 6, 2019
| @@ -1,38 +1,3 @@ | |||
| /** @type {function(number, number=)} */ | |||
Member
There was a problem hiding this comment.
It may be worth replacing this with
#if ASSERTIONS
function Pointer_stringify() {
abort("this function has been removed - you should use [..]");
}
#endif
which would help debug builds direct people to what they need to do.
58a3e6a to
838f297
Compare
Collaborator
Author
|
Ok, added it back with an error message. |
gittup
added a commit
to gittup/Effekseer
that referenced
this pull request
May 31, 2021
Pointer_stringify() was deprecated in emscripten (emscripten-core/emscripten#8011)
durswd
pushed a commit
to effekseer/Effekseer
that referenced
this pull request
Jun 1, 2021
Pointer_stringify() was deprecated in emscripten (emscripten-core/emscripten#8011)
durswd
pushed a commit
to effekseer/Effekseer
that referenced
this pull request
Jun 1, 2021
Pointer_stringify() was deprecated in emscripten (emscripten-core/emscripten#8011)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the last references to Pointer_stringify() from the codebase.