Remove BINARYEN_METHOD #7836
Merged
Remove BINARYEN_METHOD #7836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think once we simplify the wasm<->JS ABI more, it should get easier for us or someone else to come up with a way to have dual-build (or related functionality like sharing JS glue between more than one wasm module). |
dschuff
approved these changes
Jan 9, 2019
DrJosh9000
added a commit
to DrJosh9000/pce
that referenced
this pull request
Mar 1, 2019
Hi! I'm a massive fan of your work. Thanks so much for making Macintosh emulation in the browser happen. I got the following errors in config.log when attempting to `./pcejs_build build macplus`: shared:ERROR: Invalid command line option -s BINARYEN_METHOD=native-wasm,asmjs: Starting from Emscripten 1.38.23, Emscripten now always builds either to Wasm (-s WASM=1 - default), or to asm.js (-s WASM=0), other methods are not supported (https:#github.com/emscripten-core/emscripten/pull/7836) shared:ERROR: Invalid command line option -s PRECISE_I64_MATH=0: Starting from Emscripten 1.38.26, PRECISE_I64_MATH is always enabled (https:#github.com/emscripten-core/emscripten/pull/7935) This patch makes it build, and I get some output in dist/, but I haven't checked if the output works.
th-otto
pushed a commit
to th-otto/pce
that referenced
this pull request
Nov 25, 2019
Hi! I'm a massive fan of your work. Thanks so much for making Macintosh emulation in the browser happen. I got the following errors in config.log when attempting to `./pcejs_build build macplus`: shared:ERROR: Invalid command line option -s BINARYEN_METHOD=native-wasm,asmjs: Starting from Emscripten 1.38.23, Emscripten now always builds either to Wasm (-s WASM=1 - default), or to asm.js (-s WASM=0), other methods are not supported (https:#github.com/emscripten-core/emscripten/pull/7836) shared:ERROR: Invalid command line option -s PRECISE_I64_MATH=0: Starting from Emscripten 1.38.26, PRECISE_I64_MATH is always enabled (https:#github.com/emscripten-core/emscripten/pull/7935) This patch makes it build, and I get some output in dist/, but I haven't checked if the output works.
dalcde
added a commit
to dalcde/pyodide
that referenced
this pull request
Dec 28, 2020
This has been removed since 1.38.23, and is always set to native-wasm when we set WASM=1. See emscripten-core/emscripten#7836
dalcde
added a commit
to dalcde/pyodide
that referenced
this pull request
Dec 28, 2020
This has been removed since 1.38.23, and is always set to native-wasm when we set WASM=1. See emscripten-core/emscripten#7836
dalcde
added a commit
to pyodide/pyodide
that referenced
this pull request
Dec 28, 2020
This has been removed since 1.38.23, and is always set to native-wasm when we set WASM=1. See emscripten-core/emscripten#7836
joemarshall
pushed a commit
to joemarshall/pyodide
that referenced
this pull request
Jan 3, 2021
This has been removed since 1.38.23, and is always set to native-wasm when we set WASM=1. See emscripten-core/emscripten#7836
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #7831. This removes BINARYEN_METHOD, which means that if you build with WASM you get wasm, and have no option for an asm.js fallback, and if you build with WASM=0 you get asm.js.
This removes and simplifies a bunch of things, so it seems worth it. We do lose the
BINARYEN_METHOD=wasm-native,asmjsoption which let a single build run either way. That was useful for debugging back when asm.js worked well but not wasm, but those days are far in the past. Another use is to have a single build for both, but it was always a very unoptimized "compromise" build, and not recommended, so removing it avoids a possible footgun for users (if a single build is crucial for people, we should look into a more proper way to do it).