Add support for llvm.sin.f(32|64) intrinsics#4353
Merged
kripken merged 2 commits intoemscripten-core:incomingfrom May 27, 2016
Merged
Add support for llvm.sin.f(32|64) intrinsics#4353kripken merged 2 commits intoemscripten-core:incomingfrom
kripken merged 2 commits intoemscripten-core:incomingfrom
Conversation
Member
|
Looks good, thanks. Please rebase (and then Also please add a test. Can grep for the similar functions next to it, in |
bb3a90e to
def5b5a
Compare
Contributor
Author
|
Thanks about the rebase tip. It makes the history so much cleaner! I greped for each of the following strings inside
Are you aware of a more specific folder or file where I should find the tests? |
Member
|
Looks like the relevant tests are in |
Contributor
Author
|
Done :) |
Member
|
Thanks! |
varkor
added a commit
to varkor/emscripten
that referenced
this pull request
Dec 23, 2017
This fixes emscripten-core#5976. I’m using emscripten-core#4353 as a model.
varkor
added a commit
to varkor/emscripten
that referenced
this pull request
Dec 23, 2017
This fixes emscripten-core#5976. I’m using emscripten-core#4353 as a model.
varkor
added a commit
to varkor/emscripten
that referenced
this pull request
Dec 28, 2017
This fixes emscripten-core#5976. I’m using emscripten-core#4353 as a model.
varkor
added a commit
to varkor/emscripten
that referenced
this pull request
Dec 28, 2017
This fixes emscripten-core#5976. I’m using emscripten-core#4353 as a model.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for the llvm.sin.f(32|64) intrinsic to Emscripten. More details can be found in the issue #4338. The accompanying change to fastcomp is in pull request emscripten-core/emscripten-fastcomp#143