Fix GL_SHADING_LANGUAGE_VERSION#4070
Merged
kripken merged 1 commit intoemscripten-core:incomingfrom Feb 2, 2016
rdb:patch-1
Merged
Fix GL_SHADING_LANGUAGE_VERSION#4070kripken merged 1 commit intoemscripten-core:incomingfrom rdb:patch-1
kripken merged 1 commit intoemscripten-core:incomingfrom
rdb:patch-1
Conversation
Fix the value of the GL_SHADING_LANGUAGE_VERSION string to conform to the OpenGL ES 2 and 3 specifications (sections 6.1.5/6.1.6 resp.)
rdb
added a commit
to panda3d/panda3d
that referenced
this pull request
Feb 2, 2016
Collaborator
|
Thanks, this looks good! Can you add a commit in this PR that adds your name in |
Contributor
Author
|
My name already is in AUTHORS. |
kripken
added a commit
that referenced
this pull request
Feb 2, 2016
Fix GL_SHADING_LANGUAGE_VERSION
Member
|
Nice. Merged, thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenGL ES 2 specification section 6.1.5 and OpenGL ES 3 specification section 6.1.6 state:
Emscripten misses the second "ES" in there. This tripped up our engine, which expects a conforming string. This patch fixes that.