Include <stdlib.h> in test_fetch_*.cpp files#26107
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Jan 14, 2026
Merged
Include <stdlib.h> in test_fetch_*.cpp files#26107sbc100 merged 1 commit intoemscripten-core:mainfrom
sbc100 merged 1 commit intoemscripten-core:mainfrom
Conversation
These files use `exit()`, which requires `#include <stdlib.h>`, but didn't have the include. These didn't error out because `libcxx/include/math.h` used to contain `#include <stdlib.h>` but not anymore. It was removed in llvm/llvm-project#139586, which is included in LLVM 21.
sbc100
approved these changes
Jan 14, 2026
inolen
pushed a commit
to inolen/emscripten
that referenced
this pull request
Feb 13, 2026
These files use `exit()`, which requires `#include <stdlib.h>`, but didn't have the include. These didn't error out because `libcxx/include/math.h` used to contain `#include <stdlib.h>` but not anymore. It was removed in llvm/llvm-project#139586, which is included in LLVM 21.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These files use
exit(), which requires#include <stdlib.h>, but didn't have the include. These didn't error out becauselibcxx/include/math.hused to contain#include <stdlib.h>but not anymore. It was removed in llvm/llvm-project#139586, which is included in LLVM 21.