Be flexible regarding executable extensions. NFC#25960
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Dec 17, 2025
Merged
Be flexible regarding executable extensions. NFC#25960sbc100 merged 1 commit intoemscripten-core:mainfrom
sbc100 merged 1 commit intoemscripten-core:mainfrom
Conversation
dschuff
reviewed
Dec 16, 2025
sbc100
added a commit
that referenced
this pull request
Dec 16, 2025
In particular, on windows, when looking for llvm / binaryen / emscripten entry points allow them to end with the normal set of executable extensions. This allows folks use, for example, a clang.bat wrapper around clang and also allows us to start using `emcc.exe` over `emcc.bat` at some point. See emscripten-core#24858
Collaborator
Author
|
ptal |
kripken
approved these changes
Dec 17, 2025
inolen
pushed a commit
to inolen/emscripten
that referenced
this pull request
Feb 13, 2026
This used to be .bat file but no longer after emscripten-core#24907 Split out from emscripten-core#25960
inolen
pushed a commit
to inolen/emscripten
that referenced
this pull request
Feb 13, 2026
In particular, on windows, when looking for llvm / binaryen / emscripten entry points allow them to end with the normal set of executable extensions. This allows folks use, for example, a clang.bat wrapper around clang and also allows us to start using `emcc.exe` over `emcc.bat` at some point. See emscripten-core#24858 The old `exe_suffix` helper still exists but is now moved to the test framework.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In particular, on windows, when looking for llvm / binaryen / emscripten entry points allow them to end with the normal set of executable extensions.
This allows folks use, for example, a clang.bat wrapper around clang and also allows us to start using
emcc.exeoveremcc.batat some point. See #24858The old
exe_suffixhelper still exists but is now moved to the test framework.