Fix lsan.test_dylink_iostream after #25449#25474
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Oct 2, 2025
Merged
Conversation
juj
approved these changes
Oct 2, 2025
The code didn't take into about that system_libs could also contains flags such as `--whole-archive`. In this particular test the value of `system_libs` is: ``` ['-lGL-getprocaddr', '-lal', '-lhtml5', '-lstubs-debug', '-lc-debug', '-ldlmalloc-debug', '-lcompiler_rt', '--whole-archive', '-lc++-debug-noexcept', '--no-whole-archive', '-lc++abi-debug-noexcept', '-lsockets', '--whole-archive', '-llsan_rt', '--no-whole-archive', '-llsan_common_rt', '-lsanitizer_common_rt'] ```
dschuff
approved these changes
Oct 2, 2025
inolen
pushed a commit
to inolen/emscripten
that referenced
this pull request
Feb 13, 2026
…-core#25474) This failure was causing the emscripten-reeleases roller to fail. The code didn't take into about that system_libs could also contains flags such as `--whole-archive`. In this particular test the value of `system_libs` is: ``` ['-lGL-getprocaddr', '-lal', '-lhtml5', '-lstubs-debug', '-lc-debug', '-ldlmalloc-debug', '-lcompiler_rt', '--whole-archive', '-lc++-debug-noexcept', '--no-whole-archive', '-lc++abi-debug-noexcept', '-lsockets', '--whole-archive', '-llsan_rt', '--no-whole-archive', '-llsan_common_rt', '-lsanitizer_common_rt'] ``` Fixes: emscripten-core#25472
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This failure was causing the emscripten-reeleases roller to fail.
The code didn't take into about that system_libs could also contains flags such as
--whole-archive.In this particular test the value of
system_libsis:Fixes: #25472