Update compiler-rt to LLVM 20.1.4#24357
Merged
aheejin merged 12 commits intoemscripten-core:mainfrom May 22, 2025
Merged
Conversation
In llvm/llvm-project#108883, `GetThreadStackAndTls`'s API changed from ``` void GetThreadStackAndTls(bool main, uptr *stk_addr, uptr *stk_size, uptr *tls_addr, uptr *tls_size); ``` to ``` void GetThreadStackAndTls(bool main, uptr *stk_begin, uptr *stk_end, uptr *tls_begin, uptr *tls_end); ``` So this fixes `sanitizer_emscripten.cpp`'s `GetThreadStackAndTls` accordingly. Also this changes the variable names to match those of the header (https://github.com/llvm/llvm-project/blob/ec28b8f9cc7f2ac187d8a617a6d08d5e56f9120e/compiler-rt/lib/sanitizer_common/sanitizer_common.h#L86-L87)
This is an automatic change generated by tools/maint/rebaseline_tests.py. The following (9) test expectation files were updated by running the tests with `--rebaseline`: ``` other/codesize/test_codesize_cxx_ctors1.size: 129217 => 129319 [+102 bytes / +0.08%] other/codesize/test_codesize_cxx_ctors2.size: 128610 => 128712 [+102 bytes / +0.08%] other/codesize/test_codesize_cxx_except.size: 170838 => 170940 [+102 bytes / +0.06%] other/codesize/test_codesize_cxx_except_wasm.size: 144593 => 144695 [+102 bytes / +0.07%] other/codesize/test_codesize_cxx_except_wasm_legacy.size: 142168 => 142270 [+102 bytes / +0.07%] other/codesize/test_codesize_cxx_lto.size: 121938 => 122042 [+104 bytes / +0.09%] other/codesize/test_codesize_cxx_mangle.size: 232596 => 232698 [+102 bytes / +0.04%] other/codesize/test_codesize_cxx_noexcept.size: 131780 => 131882 [+102 bytes / +0.08%] other/codesize/test_codesize_cxx_wasmfs.size: 169161 => 169263 [+102 bytes / +0.06%] Average change: +0.07% (+0.04% - +0.09%) ```
Member
Author
|
Ran all asan, lsan, and ubsan tests locally and these are the failing tests. But they fail in the main branch too. And the error messages don't look like sanitizer issues.
|
Member
Author
|
The CI's test-esm-integration error says: Do you have any idea what this is about? |
Collaborator
Unrelated. Should be fixed on main now. Feel free to ignore it. |
sbc100
approved these changes
May 19, 2025
ChangeLog.md
Outdated
|
|
||
| 4.0.9 (in development) | ||
| ---------------------- | ||
| - compiler-rt was updated to LLVM 20.1.4. (#24357) |
This is an automatic change generated by tools/maint/rebaseline_tests.py. The following (9) test expectation files were updated by running the tests with `--rebaseline`: ``` other/codesize/test_codesize_cxx_ctors1.size: 129654 => 129756 [+102 bytes / +0.08%] other/codesize/test_codesize_cxx_ctors2.size: 129039 => 129141 [+102 bytes / +0.08%] other/codesize/test_codesize_cxx_except.size: 171324 => 171426 [+102 bytes / +0.06%] other/codesize/test_codesize_cxx_except_wasm.size: 144770 => 144872 [+102 bytes / +0.07%] other/codesize/test_codesize_cxx_except_wasm_legacy.size: 142360 => 142462 [+102 bytes / +0.07%] other/codesize/test_codesize_cxx_lto.size: 121882 => 121986 [+104 bytes / +0.09%] other/codesize/test_codesize_cxx_mangle.size: 235388 => 235490 [+102 bytes / +0.04%] other/codesize/test_codesize_cxx_noexcept.size: 132027 => 132129 [+102 bytes / +0.08%] other/codesize/test_codesize_cxx_wasmfs.size: 169897 => 169999 [+102 bytes / +0.06%] Average change: +0.07% (+0.04% - +0.09%) ```
sbc100
approved these changes
May 21, 2025
Lukasdoe
pushed a commit
to Lukasdoe/emscripten
that referenced
this pull request
Jun 19, 2025
This updates compiler-rt to LLVM 20.1.4. Additional change: - Reflect GetThreadStackAndTls's API change: emscripten-core@a463f5a In llvm/llvm-project#108883, `GetThreadStackAndTls`'s API changed from ``` void GetThreadStackAndTls(bool main, uptr *stk_addr, uptr *stk_size, uptr *tls_addr, uptr *tls_size); ``` to ``` void GetThreadStackAndTls(bool main, uptr *stk_begin, uptr *stk_end, uptr *tls_begin, uptr *tls_end); ``` So this fixes `sanitizer_emscripten.cpp`'s `GetThreadStackAndTls` accordingly. Also this changes the variable names to match those of the header.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates compiler-rt to LLVM 20.1.4.
Additional change:
In Reland "[sanitizer] Fix partially initialized static TLS range" llvm/llvm-project#108883,
GetThreadStackAndTls's API changed fromsanitizer_emscripten.cpp'sGetThreadStackAndTlsaccordingly. Also this changes the variable names to match those of the header.