Cleanup lock files in UNIX#24035
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Apr 2, 2025
Merged
Conversation
See tox-dev/filelock#31 And https://stackoverflow.com/a/51070775 Without this change the `cache/symbol_lists` directory ends up full of many lock files that might never get cleaned up (At least since emscripten-core#24029 landed).
89502dc to
dd68169
Compare
sbc100
added a commit
to sbc100/filelock
that referenced
this pull request
Apr 2, 2025
This avoids leaving orphan locks files around after we are done when them. See emscripten-core/emscripten#24035 Fixes: tox-dev#31
sbc100
added a commit
to sbc100/filelock
that referenced
this pull request
Apr 2, 2025
This avoids leaving orphan locks files around after we are done when them. See emscripten-core/emscripten#24035 Fixes: tox-dev#31
kripken
approved these changes
Apr 2, 2025
Member
kripken
left a comment
There was a problem hiding this comment.
Not an expert on this but it seems right and upstream approved it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See tox-dev/filelock#31 and https://stackoverflow.com/a/51070775.
Without this change the
cache/symbol_listsdirectory ends up full of many lock files that might never get cleaned up (At least since #24029 landed).I'm also sending this change upstream: tox-dev/filelock#408