Conversation
9a6c62e to
5df4e2d
Compare
2805f72 to
e3f07cd
Compare
kripken
approved these changes
Aug 25, 2023
Member
|
Do we have a good error for this? I imagine the compiler could say, "glfwInit is a missing symbol so you probably want to add -lglfw" or such? |
Collaborator
Author
I think it will just say |
Member
|
I see. Well, it's probably good enough, hopefully googling for that error will end up here... and there is the changelog help text. |
4634d77 to
0587533
Compare
This changes the default behaviour to match that of STRICT mode and MINIMAL_RUNTIME node. We made a similar change for USE_SDL back in #18443. As part of this change I also updated the code that maps `-l` flags to JS libraries. In some cases we also want these to set the corresponding `-sUSE_XXX` setting.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Mar 3, 2026
The USE_GLFW setting has been zero by default since emscripten-core#19939
sbc100
added a commit
that referenced
this pull request
Mar 4, 2026
The `USE_GLFW` setting has been zero by default since #19939
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the default behaviour to match that of STRICT mode and MINIMAL_RUNTIME node.
We made a similar change for USE_SDL back in #18443.
As part of this change I also updated the code that maps
-lflags to JS libraries. In some cases we also want these to set the corresponding-sUSE_XXXsetting.