Conversation
kripken
reviewed
Apr 13, 2023
kripken
approved these changes
Apr 13, 2023
4572207 to
85e7a12
Compare
IIUC `sbrk.c` was implicitly being excluded from LTO by being added to `libmalloc` instead of `libc`, even though it makes more sense in `libc`. sbrk depends on `emscripten_get_heap_size`, so an alternative to this change would be to move `emscripten_get_heap_size` into libmalloc, but since neither of those two files depends on the malloc type I think this approach makes more sense. Split out from #18905
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 24, 2024
This effectively reverts emscripten-core#19174 Fixes: emscripten-core#21223
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 25, 2024
This effectively reverts emscripten-core#19174 Fixes: emscripten-core#21223
Merged
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 25, 2024
This effectively reverts emscripten-core#19174 Fixes: emscripten-core#21223
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 25, 2024
This effectively reverts emscripten-core#19174 Fixes: emscripten-core#21223
sbc100
added a commit
that referenced
this pull request
Oct 25, 2024
MPurscheUnity
pushed a commit
to Unity-Technologies/emscripten
that referenced
this pull request
May 14, 2025
This effectively reverts emscripten-core#19174 Fixes: emscripten-core#21223
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IIUC
sbrk.cwas implicitly being excluded from LTO by being added tolibmallocinstead oflibc, even though it makes more sense inlibc.sbrk depends on
emscripten_get_heap_size, so an alternative to this change would be to moveemscripten_get_heap_sizeinto libmalloc, but since neither of those two files depends on the malloc type I think this approach makes more sense.Split out from #18905