Update MINIMUM_NODE_VERSION to 10.19.0 and add testing#18465
Merged
Conversation
c1c6fb7 to
59f2a81
Compare
59f2a81 to
68b2759
Compare
68b2759 to
15b02da
Compare
kripken
approved these changes
Jan 4, 2023
15b02da to
5b23b7b
Compare
sbc100
added a commit
that referenced
this pull request
Jan 14, 2023
This, along with #18465 (which run tests on the oldest supported version of node) should pave the way for us to update the emsdk version node to something a little more modern. This first thing I do with this setting is use it do disable `NODEJS_CATCH_REJECTION` by default when we are targeting node 15 and above.
sbc100
added a commit
that referenced
this pull request
Jan 14, 2023
This, along with #18465 (which run tests on the oldest supported version of node) should pave the way for us to update the emsdk version node to something a little more modern. See emscripten-core/emsdk#829 This first thing I do with this setting is use it do disable `NODEJS_CATCH_REJECTION` by default when we are targeting node 15 and above.
sbc100
added a commit
that referenced
this pull request
Jan 14, 2023
This, along with #18465 (which run tests on the oldest supported version of node) should pave the way for us to update the emsdk version node to something a little more modern. See emscripten-core/emsdk#829 This first thing I do with this setting is use it do disable `NODEJS_CATCH_REJECTION` by default when we are targeting node 15 and above.
sbc100
added a commit
that referenced
this pull request
Jan 14, 2023
This, along with #18465 (which run tests on the oldest supported version of node) should pave the way for us to update the emsdk version node to something a little more modern. See emscripten-core/emsdk#829 This first thing I do with this setting is use it do disable `NODEJS_CATCH_REJECTION` by default when we are targeting node 15 and above.
sbc100
added a commit
that referenced
this pull request
Jan 19, 2023
This, along with #18465 (which run tests on the oldest supported version of node) should pave the way for us to update the emsdk version node to something a little more modern. See emscripten-core/emsdk#829 This first thing I do with this setting is use it do disable `NODEJS_CATCH_REJECTION` by default when we are targeting node 15 and above.
sbc100
added a commit
that referenced
this pull request
Jan 20, 2023
This, along with #18465 (which run tests on the oldest supported version of node) should pave the way for us to update the emsdk version node to something a little more modern. See emscripten-core/emsdk#829 This first thing I do with this setting is use it do disable `NODEJS_CATCH_REJECTION` by default when we are targeting node 15 and above.
sbc100
added a commit
that referenced
this pull request
Jan 20, 2023
This, along with #18465 (which run tests on the oldest supported version of node) should pave the way for us to update the emsdk version node to something a little more modern. See emscripten-core/emsdk#829 This first thing I do with this setting is use it do disable `NODEJS_CATCH_REJECTION` by default when we are targeting node 15 and above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We broke compat with 4.1.1 a while back (when we started using var and const in the JS compiler).