Skip test that fails in STACK_OVERFLOW_CHECK mode. NFC#16821
Merged
Conversation
This is the only test that currently fails in the core2ss mode.
kripken
approved these changes
Apr 26, 2022
Member
kripken
left a comment
There was a problem hiding this comment.
Please open an issue for this if you aren't investigating it atm, this sounds like a possible serious bug.
Collaborator
Author
|
I agree it could be serious, but it seems limited to |
sbc100
added a commit
that referenced
this pull request
Apr 27, 2022
Member
|
Good question, I'm not aware of current users. It's an experiment. Seems very low priority then. We can probably remove lazy-load-code at some point, especially once wasm-split is stable. |
sbc100
added a commit
that referenced
this pull request
Apr 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the only test that currently fails in the core2ss mode.