Conversation
Collaborator
Author
|
Crap I thought prefixing the PR with |
kripken
approved these changes
Feb 10, 2022
Member
|
Optimally it would skip the non-doc tests, yeah. But we do have @sbc100 did you have any more thoughts on resolving this? |
sbc100
approved these changes
Feb 10, 2022
Collaborator
Trying to figure out which test to run on a given PR is fairly non-trivial... we could try to do it based on magic comments in the PR description or based on which files are touched, but I'm not sure its worth it. WDYT? |
bas524
added a commit
to bas524/poco
that referenced
this pull request
Dec 8, 2023
add NotImplemented exception for unsupported platforms exculude <sys/sendfile.h> for POCO_EMSCRIPTEN, because https:// github.com/emscripten-core/emscripten/pull/16234
matejk
pushed a commit
to pocoproject/poco
that referenced
this pull request
Dec 11, 2023
* add sendfile method for streamsocket * add mswsock.lib to the project files and templates * remove /DPOCO_NO_AUTOMATIC_LIBS for cmake windows build * merge from upstream * merge from upstream * fix code stile add NotImplemented exception for unsupported platforms exculude <sys/sendfile.h> for POCO_EMSCRIPTEN, because https:// github.com/emscripten-core/emscripten/pull/16234 * add iostream include for std::cout * fix compilation for emscripten (wrap sendfile)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #16200.
Files was removed in #14248.