Skip to content

Merge pull request #11 from SilentFlyBy/master#1

Merged
emoldtmann merged 1 commit intoemoldtmann:masterfrom
dolanmiu:master
Apr 18, 2018
Merged

Merge pull request #11 from SilentFlyBy/master#1
emoldtmann merged 1 commit intoemoldtmann:masterfrom
dolanmiu:master

Conversation

@emoldtmann
Copy link
Copy Markdown
Owner

Also allow js string and string[] where Strarray is required

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • The package does not provide its own types, and you can not add them.
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

If removing a declaration:

  • If a package was never on DefinitelyTyped, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

Also allow js string and string[] where Strarray is required
@emoldtmann emoldtmann merged commit 8d6a221 into emoldtmann:master Apr 18, 2018
emoldtmann pushed a commit that referenced this pull request Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants