Only run App::ui if the application is visible#7950
Merged
Conversation
|
Preview available at https://egui-pr-preview.github.io/pr/7950-emilkonly-logic View snapshot changes at kitdiff |
App::ui if the application is visible
This was referenced Mar 2, 2026
Masterchef365
pushed a commit
to Masterchef365/egui
that referenced
this pull request
Apr 3, 2026
* Closes emilk#5113 * Part of emilk#5112 * Part of emilk#5136 If the application is invisible (occluded or minimized), and the user calls `.request_repaint`, then we should call `App::logic`, but NOT `App::ui`. There are still some situations where `App::logic` is not called when it should be, but at least now we can skip running the UI code when the app is invisible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
App::logic#5113App::logiceven when hidden #5112request_repaintignored if minimized #5136If the application is invisible (occluded or minimized), and the user calls
.request_repaint, then we should callApp::logic, but NOTApp::ui.There are still some situations where
App::logicis not called when it should be, but at least now we can skip running the UI code when the app is invisible.