Add close_button option to test_viewports#4907
Merged
emilk merged 3 commits intoemilk:masterfrom Aug 26, 2024
Merged
Conversation
This reverts commit ac86281.
emilk
approved these changes
Aug 5, 2024
Owner
|
Thanks! |
Contributor
Author
486c
pushed a commit
to 486c/egui
that referenced
this pull request
Oct 9, 2024
This make the test excercise the window recreation logic, that resulted in several bugs - see emilk#4862 Adds a check box that turns the close button on and off for child windows
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
This make the test excercise the window recreation logic, that resulted in several bugs - see emilk#4862 Adds a check box that turns the close button on and off for child windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This make the test excercise the window recreation logic, that resulted in several bugs - see #4862
Adds a check box that turns the close button on and off for child windows