Fix: panic when dragging window between monitors of different pixels_per_point#4868
Merged
emilk merged 14 commits intoemilk:masterfrom Sep 17, 2024
Merged
Fix: panic when dragging window between monitors of different pixels_per_point#4868emilk merged 14 commits intoemilk:masterfrom
emilk merged 14 commits intoemilk:masterfrom
Conversation
emilk
requested changes
Sep 17, 2024
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
emilk
approved these changes
Sep 17, 2024
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
…per_point (emilk#4868) Fix: panic when dragging window between monitors of different pixels_per_point This will continue to help us as we develop `egui`. I hope you agree with my defense of `panic`. * Relate emilk#3959 * Relate emilk#4088 * Closes emilk#4178 * Closes emilk#4179 There is also a way to add log if necessary. ``` log::debug!("Anti-panic behavior occurs"); ``` --------- Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: panic when dragging window between monitors of different pixels_per_point
This will continue to help us as we develop
egui.I hope you agree with my defense of
panic.Related Crash when changing a viewport aspect, that requires window recreation #3959
Related Fix panic when dragging window between monitors of different
pixels_per_point#4088Closes There is on very rare occasions a case where a panic occurred #4178
Closes There is on very rare occasions a case where a panic occurred at line 152 of layers.rs #4179
There is also a way to add log if necessary.