Force canvas/text input focus on touch for iOS web browsers#4848
Merged
jprochazk merged 1 commit intoemilk:masterfrom Jul 23, 2024
Merged
Force canvas/text input focus on touch for iOS web browsers#4848jprochazk merged 1 commit intoemilk:masterfrom
jprochazk merged 1 commit intoemilk:masterfrom
Conversation
7d4775d to
c0bc79d
Compare
|
This is a big step forward for egui mobile web, ty |
emilk
reviewed
Jul 23, 2024
c0bc79d to
4c38228
Compare
jprochazk
approved these changes
Jul 23, 2024
486c
pushed a commit
to 486c/egui
that referenced
this pull request
Oct 9, 2024
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #4569
is_mobilefromeframe/src/web/text_agent.rstoeframe/src/web/mod.rsand used it ineframe/src/web/events.rspointerdowneventpointerupevent and forced the canvas to be focused when the event is received and therefore the on-screen keyboard appearingThis PR tries to fix iOS browsers issue where it doesn't focus the canvas/text input on touch and therefore not showing the on-screen keyboard. It does it by force focusing the canvas on
pointerup