Treat Event::PointerGone as PointerEvent::Released#4419
Merged
emilk merged 18 commits intoemilk:masterfrom May 11, 2024
Merged
Conversation
drag_stopped_by() not detected after mouse release.drag_stopped_by() not detected after mouse release.
drag_stopped_by() not detected after mouse release.PointerButton.
PointerButton.Event::PointerGone occurs, it is treated as PointerEvent::Released.
emilk
approved these changes
May 10, 2024
Owner
emilk
left a comment
There was a problem hiding this comment.
Makes sense, but please revert unrelated changea
Comment on lines
-459
to
-464
| let button_suffix = if button == egui::PointerButton::Primary { | ||
| // Reduce visual clutter in common case: | ||
| String::default() | ||
| } else { | ||
| format!(" by {button:?} button") | ||
| }; |
emilk
approved these changes
May 11, 2024
Event::PointerGone occurs, it is treated as PointerEvent::Released.Event::PointerGone as PointerEvent::Released
emilk
added a commit
that referenced
this pull request
May 22, 2024
* Closes #3157 If the mouse leaves the canvas when dragging a slider, the slider will still move. --- To support this, I had to revert #4419 Despite that, I fail to reproduce the two issues it claimed to solve: * #4406 may have been solved in another way by this PR * #4418 I cannot reproduce on Mac. If it is still a problem, I think it should be solved by triggering a `PointerEvent::Released` when focus is lost (i.e. on alt-tab), and not on `PointerGone`
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
* Closes emilk#4406 * Closes emilk#4418 If `Event::PointerGone` occurs, it is treated as `PointerEvent::Released`.
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
* Closes emilk#3157 If the mouse leaves the canvas when dragging a slider, the slider will still move. --- To support this, I had to revert emilk#4419 Despite that, I fail to reproduce the two issues it claimed to solve: * emilk#4406 may have been solved in another way by this PR * emilk#4418 I cannot reproduce on Mac. If it is still a problem, I think it should be solved by triggering a `PointerEvent::Released` when focus is lost (i.e. on alt-tab), and not on `PointerGone`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
Event::PointerGoneoccurs, it is treated asPointerEvent::Released.