Fix: A symptom of characters being copied when there are multiple TextEdits.#4374
Closed
rustbasic wants to merge 9 commits intoemilk:masterfrom
Closed
Fix: A symptom of characters being copied when there are multiple TextEdits.#4374rustbasic wants to merge 9 commits intoemilk:masterfrom
rustbasic wants to merge 9 commits intoemilk:masterfrom
Conversation
emilk
reviewed
Apr 21, 2024
|
|
||
| // target ID for IME candidate. | ||
| #[cfg_attr(feature = "serde", serde(skip))] | ||
| pub(crate) ime_target_id: Id, |
Owner
There was a problem hiding this comment.
Won't this always be the same Id as the key used to find TextEditState?
Contributor
Author
There was a problem hiding this comment.
Yes, it only stores TextEdit ID.
It's currently working fine without any problems.
If something is wrong or needs to be fixed, please fix it or let me know.
Owner
There was a problem hiding this comment.
That the code is working fine is not enough. I need to maintain this, and so I need to understand it. Storing the Id here makes no sense to me, since it is already the key.
Owner
|
Blocked on #4358 |
Contributor
Author
|
for example, Please review. |
emilk
pushed a commit
that referenced
this pull request
Aug 28, 2024
…oses focus. (#4896) Fix: Ensures correct IME behavior when the text input area gains or loses focus. Fix: Handling `state.ime_enabled` in multiple `TextEdit`. Fix: A symptom of characters being copied when there are multiple TextEdits. * Related #4137 * Related #4358 * Closes #4374 * Related #4436 * Related #4794 * Related #4908 * Related #5008 Fix Issues: When focus is moved elsewhere, you must set `state.ime_enabled = false`, otherwise the IME will have problems when focus returns. Fix Issues: A symptom of characters being copied when there are multiple TextEdits. Deletes all current `IME events`, preventing them from being copied to `other TextEdits`, without saving the `TextEdit ID`, ( Related Issues: Some `LINUX` seem to trigger an IME enable event on startup. So, when we gained focus, we do `state.ime_enabled = false`. )
486c
pushed a commit
to 486c/egui
that referenced
this pull request
Oct 9, 2024
…oses focus. (emilk#4896) Fix: Ensures correct IME behavior when the text input area gains or loses focus. Fix: Handling `state.ime_enabled` in multiple `TextEdit`. Fix: A symptom of characters being copied when there are multiple TextEdits. * Related emilk#4137 * Related emilk#4358 * Closes emilk#4374 * Related emilk#4436 * Related emilk#4794 * Related emilk#4908 * Related emilk#5008 Fix Issues: When focus is moved elsewhere, you must set `state.ime_enabled = false`, otherwise the IME will have problems when focus returns. Fix Issues: A symptom of characters being copied when there are multiple TextEdits. Deletes all current `IME events`, preventing them from being copied to `other TextEdits`, without saving the `TextEdit ID`, ( Related Issues: Some `LINUX` seem to trigger an IME enable event on startup. So, when we gained focus, we do `state.ime_enabled = false`. )
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
…oses focus. (emilk#4896) Fix: Ensures correct IME behavior when the text input area gains or loses focus. Fix: Handling `state.ime_enabled` in multiple `TextEdit`. Fix: A symptom of characters being copied when there are multiple TextEdits. * Related emilk#4137 * Related emilk#4358 * Closes emilk#4374 * Related emilk#4436 * Related emilk#4794 * Related emilk#4908 * Related emilk#5008 Fix Issues: When focus is moved elsewhere, you must set `state.ime_enabled = false`, otherwise the IME will have problems when focus returns. Fix Issues: A symptom of characters being copied when there are multiple TextEdits. Deletes all current `IME events`, preventing them from being copied to `other TextEdits`, without saving the `TextEdit ID`, ( Related Issues: Some `LINUX` seem to trigger an IME enable event on startup. So, when we gained focus, we do `state.ime_enabled = false`. )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Event::Ime#4358Fix: A symptom of characters being copied when there are multiple TextEdits.