The contents of #4284 have been reverted#4290
Closed
rustbasic wants to merge 24 commits intoemilk:masterfrom
Closed
The contents of #4284 have been reverted#4290rustbasic wants to merge 24 commits intoemilk:masterfrom
rustbasic wants to merge 24 commits intoemilk:masterfrom
Conversation
Owner
|
Which commit in https://github.com/emilk/egui/pull/4284/commits caused a problem for you? |
Contributor
Author
Yes, #4284 I haven't looked into it in detail yet, other than that it caused a problem and that reverting it solves it. |
Contributor
Author
|
If we don't may be, Even if we don't 'return`, the result of fast speed we want is still there. |
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
…since it is reportedly broken on Windows * Early-out added in emilk#4284 * Re-opens emilk#4173 😭 * Closes emilk#4289 * Closes emilk#4290
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The contents of
glowbackend #4284have been reverted,
and processed as comments.