Update resvg dependency of egui_extras#3719
Merged
emilk merged 1 commit intoemilk:masterfrom Dec 20, 2023
Merged
Conversation
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
resvgfrom v0.28 to v0.37.Remove related, unnecessary entries from
deny.toml.⚠ In example
imagesferris is scaled differently, but I guess that now it scales in expected way (takes all available space; before this PR it takes up to space that, was available at first render- it does not upscale).This PR is minimal adaptation to new
resvgapi and small related simplification, however it should be considered to update loaders (currently if svg image initially was small and was scaled up it will be blurred, see #3501). As svg image now scales over render size, problem will be more often seen now.(currently
SvgLoadertheoretically should rerender for different sizes (but I guess it will result in memory leak in that case), but refreshing is stopped earlier inDefaultTextureLoader).I have initial version of loaders update, that will fix issue with svg scaling (and also enable e.g. reloading image if file has been changed), I will submit these changes in separate PR once this one is merged.
Closes #3652.