Conversation
torokati44
reviewed
Oct 26, 2023
28 tasks
emilk
approved these changes
Nov 11, 2023
Owner
emilk
left a comment
There was a problem hiding this comment.
Sad to see so many added/duplicated dependencies, but hopefully we can fix that once we update winit and glow
Contributor
|
May I ask, which release is this going to be the part of, and when can that be expected? 👀 |
Contributor
|
The reason I asked, is that it would have been nice (for Ruffle at least) to get an egui version that updated wgpu and naga, but not yet winit and rwh. |
Collaborator
Author
|
I heard @emilk saying that the plan is to release an egui version with this (but no new winit) later this week :) |
emilk
added a commit
to rerun-io/rerun
that referenced
this pull request
Dec 1, 2023
### What * Fixes #3973 * Depends on emilk/egui#3505 ### Test Matrix Make sure to click through a few examples to cover at least points, lines and meshes. (Arkit is a good one!) * [ ] Test window-related stuff on Linux: * [ ] check that resizing the window works * [ ] that the icon shows * [ ] that file->open works * [ ] that the DPI is sane and persisted on restart * [ ] Look for any other weird regressions * [x] Mac * [x] native * [x] WebGL Firefox * [x] WebGL Chrome * [x] WebGL Safari * [x] (optional) WebGPU Chrome * [x] Linux * [x] native * [x] WebGL Firefox * [x] WebGL Chrome * [x] Windows * [x] native * [x] WebGL Firefox * [x] WebGL Chrome * [x] WebGL Edge * [ ] (optional) WebGPU Chrome * [x] Merge egui PR ### Checklist * [x] emilk/egui#3505 has been merged * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/4111) (if applicable) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4111) - [Docs preview](https://rerun.io/preview/73199e5727c18529cdbd2dd3956af17204403f96/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/73199e5727c18529cdbd2dd3956af17204403f96/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://ref.rerun.io/dev/bench/) - [Wasm size tracking](https://ref.rerun.io/dev/sizes/) --------- Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com> Co-authored-by: Antoine Beyeler <antoine@rerun.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested on M1 Mac:
all looking normal
Updated minor ahash version because 0.8.1 got yanked. Added some deny exceptions for now - we'll have to update winit soon to resolve glow related cargo deny errors (not a big issue though since we don't expect wgpu and glow backends to be used at the same time)