Conversation
Contributor
|
I add the following code to the start of GlowWinitApp.on_event() func, and found the second and third window receive some events which are not belong to them. if window_id != self.window().id() {
println!("{event:?}");
println!("window_id mismatch !");
return EventResult::Wait;
} |
zu1k
reviewed
Aug 15, 2022
Owner
Author
|
Ignoring events to the wrong window seems like a good idea, so I added that. The extra call to Does it now work as expected on Windows? |
Contributor
Yes, it works. 20220815_220324.mp4 |
Owner
Author
|
Well, that's nice! On Mac I get |
emilk
added a commit
that referenced
this pull request
Aug 20, 2022
Since #1919 we can continue the application after closing the native window. It therefore makes more sense to call `frame.close()` to close the native window, instead of `frame.quit()`.
emilk
added a commit
that referenced
this pull request
Aug 20, 2022
Since #1919 we can continue the application after closing the native window. It therefore makes more sense to call `frame.close()` to close the native window, instead of `frame.quit()`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1918
This attempts to allow opening several eframe windows after each other (one at the time).
Try it out with
cargo run -p serial_windows.This works on Windows (thanks to @zu1k), but on Mac I get
winit::event::Event::LoopDestroyedright away for the second window, and then the even loops closes.