Stop Leaking Implementation Details of Built-in Components #671
Conversation
69c934c to
1683a7e
Compare
alexlafroscia
left a comment
There was a problem hiding this comment.
Overall, I think it's a great idea to limit how these components can be interacted with and to avoid introducing a new "generation" of these built-in components.
With the exception of LinkTo, it's unclear to my what the benefit of even having these components as part of the Ember API rather than using the raw HTML elements directly, so I'm totally in agreement with not introducing new versions of them! I hope we deprecate them entirely one day, but can see how it's not worth the "churn" to do that right now.
Co-authored-by: Alex LaFroscia <alex@lafroscia.com>
I don't want this RFC to imply that it is the core teams/community's collective opinion that these components are obsolete/out-of-favor. I personally still use them and definitely find them generally useful and pleasant to use. Even after this RFC, they are still very part of the Ember first-class API, and no one should hesitate to use them, even when building new apps! We'll continue to teach them as the happy path of the learning materials too. 😄 That being said, it's totally fine and healthy to have a somewhat different opinion here, and I think eventually we will converge anyway – I don't necessarily think we will stick with this model forever. We should make sure we don't get in the way of making those alternative/experiments viable, and if there is anything that you need to make things better/easier, we should work it out to and make it happen (in separate proposals than this). On the off chance that something here would make that situation worse compared to the status quo, definitely bring it up here! |
| not believe we are at that point yet, so in the meantime, we should not stop | ||
| improving what we have. | ||
|
|
||
| ## Unresolved questions |
There was a problem hiding this comment.
Should TextSupport be available for import in the legacy addon?
This implements some of the deprecations proposed in [RFC #671][1]. The deprecations are gated behind the feature flag so they won't be visible until the RFC is merged and the feature is enabled. [1]: emberjs/rfcs#671
This implements some of the deprecations proposed in [RFC #671][1]. The deprecations are gated behind the feature flag so they won't be visible until the RFC is merged and the feature is enabled. [1]: emberjs/rfcs#671
|
We discussed this in today's framework team meeting, and we believe this proposal is ready for Final Comment Period. If you haven't had a chance to review it yet, this would be a good time to do it! 🎉 |
rwjblue
left a comment
There was a problem hiding this comment.
Awesome, thank you for writing this up @chancancode!
|
Discussed this again yesterday, and we are all in favor of moving forward.... ✋ 👍 ✋ 👍 |
|
rendered link is broken. This seems to be the right one: Sorry, just noticed this is already merged. Just came across it, opening discord after quite a while. |
This resolves a small confusion between the two RFCs.
This resolves a small confusion between the two RFCs.
This resolves a small confusion between the two RFCs.
Rendered