Closed
Conversation
rwjblue
reviewed
Jun 20, 2017
Member
rwjblue
left a comment
There was a problem hiding this comment.
My main concerns are around:
- adding more things to
LinkComponent(you already have this in the drawbacks section) - naming of
eventAction, is there another name that might work better? - if we are going to allow folks to override we should allow them to actually use the default (e.g. adding custom tracking functional would still want to call the current _invoke)
| @@ -1,52 +0,0 @@ | |||
| - Start Date: (fill me in with today's date, YYYY-MM-DD) | |||
Member
There was a problem hiding this comment.
This file shouldn't be deleted, can you bring it back?
Author
|
@rwjblue unless I'm missing something, the 3rd point is already covered. The new |
rwjblue
pushed a commit
to rwjblue/ember-test-helpers
that referenced
this pull request
Oct 9, 2017
Mostly copied/stolen from emberjs's packages/ember-testing/lib/events.js but with some tweaks to make it work without jQuery (I think those changes were made upstream in Ember as well). The long term goal here is to remove this file and have ember-test-helpers _include_ the helpers from ember-native-dom-helpers, but that will require an RFC once the changes proposed in emberjs/rfcs#230 are implemented.
rwjblue
pushed a commit
to rwjblue/ember-test-helpers
that referenced
this pull request
Oct 9, 2017
This was added in an early attempt to simplify / separate things for the "grand testing unification" RFC, but ultimately was never rolled out to folks. At this point, it has become clear that this class based system for managing test setup is not the way forward (see emberjs/rfcs#230 for details) and this module (that is unused) has just become "dead weight" maintenance wise.
rwjblue
pushed a commit
to rwjblue/ember-test-helpers
that referenced
this pull request
Oct 10, 2017
Moves all of the future deprecated code into a `legacy-0-6-x` subfolder (while preserving import paths) in order to ease implementation of emberjs/rfcs#230.
rwjblue
pushed a commit
to rwjblue/ember-test-helpers
that referenced
this pull request
Oct 10, 2017
Moves all of the future deprecated code into a `legacy-0-6-x` subfolder (while preserving import paths) in order to ease implementation of emberjs/rfcs#230.
Member
|
Moving into FCP to close for this, I think the right path forward for folks here is to not use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rendered