Skip to content
This repository was archived by the owner on Nov 11, 2017. It is now read-only.

TypeScript support#188

Closed
pittst3r wants to merge 6 commits intoemberjs:masterfrom
pittst3r:container-typescript
Closed

TypeScript support#188
pittst3r wants to merge 6 commits intoemberjs:masterfrom
pittst3r:container-typescript

Conversation

@pittst3r
Copy link
Copy Markdown

@pittst3r pittst3r commented Jan 27, 2017

Required config on the ember side: emberjs/ember.js#14896

@pittst3r
Copy link
Copy Markdown
Author

Need to tweak this to pass in node_modules to the Typescript compiler.

*/
var files = [ jsRegExp ];

if (pkg.hasTypescript) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be camel cased (isTypeScript).

@pittst3r pittst3r force-pushed the container-typescript branch from d70f542 to d0af3ba Compare January 29, 2017 21:32
@pittst3r
Copy link
Copy Markdown
Author

This requires a package-specific tsconfig.json like:

$ more packages/container/tsconfig.json
{
  "compilerOptions": {
    "target": "es2015",
    "module": "es2015",
    "moduleResolution": "node",
    "baseUrl": ".",
    "paths": {
      "*": ["packages/*/lib/index"]
    }
  },
  "include": [
    "container/**/*.ts"
  ],
  "exclude": [
    "node_modules",
    "packages",
    "**/*.d.ts"
  ]
}

@pittst3r
Copy link
Copy Markdown
Author

What do we want to do with the declaration files that will be generated?

@chadhietala
Copy link
Copy Markdown
Contributor

Has this been tested in VSCode with some typescript files to see if the type definitions are followed and TypeScript language service doesn't become over loaded? /cc @krisselden

@rwjblue
Copy link
Copy Markdown
Member

rwjblue commented Jan 30, 2017

@chadhietala - Not to my knowledge. I'm really unsure how to use VSCode for this. The main purpose here is to get things functioning so that work integrating @glimmer/di can begin.

@pittst3r
Copy link
Copy Markdown
Author

@chadhietala If you're asking if putting TS in emberjs in VSCode has been tested, yes. Type definitions are followed and I have not noticed any problems. Rebuilds while running tests in the ember repo are also working fine.

glimmer-container

@pittst3r pittst3r changed the title Typescript support WIP TypeScript support Jan 30, 2017
@rwjblue
Copy link
Copy Markdown
Member

rwjblue commented Jan 31, 2017

@robbiepitts - Is this still WIP, if yes, can you add a TODO checklist to the description?

@pittst3r
Copy link
Copy Markdown
Author

pittst3r commented Feb 1, 2017

@rwjblue Sorry, no, this is good to go. I made it WIP when I ran into some issues that turned out to be tsconfig related.

I'll update the PR description to include config details.

@pittst3r pittst3r changed the title WIP TypeScript support TypeScript support Feb 1, 2017
@rwjblue
Copy link
Copy Markdown
Member

rwjblue commented Nov 11, 2017

I'm sorry we didn't get back to this previously, but at this point this repo is unused by Ember and unmaintained.

Closing...

@rwjblue rwjblue closed this Nov 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants