Conversation
|
Need to tweak this to pass in node_modules to the Typescript compiler. |
lib/get-es6-package.js
Outdated
| */ | ||
| var files = [ jsRegExp ]; | ||
|
|
||
| if (pkg.hasTypescript) { |
There was a problem hiding this comment.
This should be camel cased (isTypeScript).
d70f542 to
d0af3ba
Compare
|
This requires a package-specific tsconfig.json like: |
|
What do we want to do with the declaration files that will be generated? |
|
Has this been tested in VSCode with some typescript files to see if the type definitions are followed and TypeScript language service doesn't become over loaded? /cc @krisselden |
|
@chadhietala - Not to my knowledge. I'm really unsure how to use VSCode for this. The main purpose here is to get things functioning so that work integrating |
|
@chadhietala If you're asking if putting TS in emberjs in VSCode has been tested, yes. Type definitions are followed and I have not noticed any problems. Rebuilds while running tests in the ember repo are also working fine. |
|
@robbiepitts - Is this still WIP, if yes, can you add a TODO checklist to the description? |
|
@rwjblue Sorry, no, this is good to go. I made it WIP when I ran into some issues that turned out to be tsconfig related. I'll update the PR description to include config details. |
|
I'm sorry we didn't get back to this previously, but at this point this repo is unused by Ember and unmaintained. Closing... |

Required config on the ember side: emberjs/ember.js#14896