Configure container to be able to use TypeScript#14896
Merged
mixonic merged 1 commit intoemberjs:masterfrom Feb 1, 2017
Merged
Configure container to be able to use TypeScript#14896mixonic merged 1 commit intoemberjs:masterfrom
container to be able to use TypeScript#14896mixonic merged 1 commit intoemberjs:masterfrom
Conversation
8139014 to
514910e
Compare
Member
|
This looks good to me. @rondale-sc and I did something similar on a not-yet-pushed branch. We can base work on this though- it seems you have been a bit more thorough wrt 🙇 Thanks for pushing all this through @robbiepitts! |
Member
|
@robbiepitts @mixonic if this requires emberjs/emberjs-build#188 as written in the PR message then how is it currently working and why wasn't emberjs/emberjs-build#188 merged yet? |
Contributor
Author
|
@Turbo87 It's not working yet but it's also not doing any harm. This PR just has config that's not being consumed, so nothing happens. Regarding the accompanying PR, just waiting on a final review and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires emberjs/emberjs-build#188
cc @rwjblue @mixonic