[FEATURE] Update to Typescript 4.8#20203
Merged
chriskrycho merged 1 commit intomasterfrom Sep 22, 2022
Merged
Conversation
wagenet
approved these changes
Sep 21, 2022
We were previously using 4.6. We'll aim to keep this up to date going forward. Here, update the dependency and then address two safety issues it caught on either 4.7 or 4.8 but did not back on 4.6.
Contributor
Author
|
Just rebased this on top of |
chriskrycho
added a commit
that referenced
this pull request
Dec 6, 2022
We won't be able to land this till we solve #20203, but it will be awesome for preventing regressions once we *do*.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were previously using 4.6. We'll aim to keep this up to date going forward.
Here, update the dependency and then address two safety issues it caught on either 4.7 or 4.8 but did not back on 4.6.
In the next PR I’ll also be adding CI support for testing a range, but only targeting 4.8 at the moment with it because we don’t want to couple ourselves to a wider range needlessly. See that PR for further details!