Revert explicit peerDependencies contracts#998
Merged
chriskrycho merged 1 commit intomasterfrom Dec 19, 2022
Merged
Conversation
I originally [thought][1] these `peerDependencies` were not breaking because users would be able to opt into them. Unfortunately, this is [not the case][2]: users on Ember 3.28 will have an older copy of these dependencies, so correctly validating these breaks consumers. [1]: #995 (comment) [2]: #997 (comment) We should bundle these into a v7.0.0 when we drop Node 14 and Ember 3.28, presumably in ~April 2023. Fixes #997
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I originally thought these
peerDependencieswere not breaking because users would be able to opt into them. Unfortunately, this is not the case: users on Ember 3.28 will have an older copy of these dependencies, so correctly validating these breaks consumers.We should bundle these into a v7.0.0 when we drop Node 14 and Ember 3.28, presumably in ~April 2023.
Fixes #997