Add emberjs/rfcs#176 support by default. #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the new modules with globals usage when the Ember version in use does not include its own modules. As discussed in a recent ember-cli team meeting.
ab4bf74 to
305ab9b
Compare
This was referenced Jul 3, 2017
Turbo87
approved these changes
Jul 3, 2017
Member
|
@rwjblue I suppose we won't backport this to Babel 5, right? |
Member
Author
|
@Turbo87 - I wasn't planning to, but we could if you thought it was required... |
Member
|
likely not necessary since we can mix addons with 5 and 6 in an app and this will create another incentive to update to Babel 6 |
Member
Author
|
Sounds good. We also did a bunch of work to make ember-cli-babel@6 work quite a ways back, so folks should not be stuck... |
1 task
siva-sundar
pushed a commit
to siva-sundar/ember-cli-babel
that referenced
this pull request
Feb 11, 2021
parallel-api: Fix "Cannot read property '_parallelBabel' of null" error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the new modules with globals usage when the Ember version in use does not include its own modules.
As discussed in a recent ember-cli team meeting.