Deprecate this.element and this.args on class-based modifiers#221
Merged
Deprecate this.element and this.args on class-based modifiers#221
this.element and this.args on class-based modifiers#221Conversation
rwjblue
requested changes
Mar 23, 2022
06fe0c5 to
f94ff29
Compare
Contributor
Author
|
For the sake of keeping merges clean and easy, this is now based on #220 and should land right after it does. |
rwjblue
reviewed
Mar 24, 2022
Member
rwjblue
left a comment
There was a problem hiding this comment.
I think this needs a rebase now?
The introduction of the `modify` hook on class-based modifiers allows users to use the `element` and both `positional` and `named` arguments directly, as arguments to `modify`, rather than having them as the class properties `this.element` and `this.args` (see #217). Accordingly, deprecate access to both `this.element` and `this.args`. (Users who want to stash the `element` on their modifier class can continue to do so directly, by assigning it from the `modify` call.)
f94ff29 to
5dafa28
Compare
rwjblue
requested changes
Mar 24, 2022
rwjblue
approved these changes
Mar 24, 2022
evoactivity
added a commit
to evoactivity/ember-autoresize-modifier
that referenced
this pull request
Oct 12, 2022
Fixes deprecation warnings ember-modifier/ember-modifier#217 ember-modifier/ember-modifier#221
jelhan
pushed a commit
to jelhan/ember-autoresize-modifier
that referenced
this pull request
Oct 15, 2022
* Move to modify hook Fixes deprecation warnings ember-modifier/ember-modifier#217 ember-modifier/ember-modifier#221
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The introduction of the
modifyhook on class-based modifiers allows users to use theelementand bothpositionalandnamedarguments directly, as arguments tomodify, rather than having them as the class propertiesthis.elementandthis.args(see #217). Accordingly, deprecate access to boththis.elementandthis.args.(Users who want to stash the
elementon their modifier class can continue to do so directly, by assigning it from themodifycall.)