chore: update linting configuration#101
Merged
chriskrycho merged 5 commits intomasterfrom Oct 26, 2021
Merged
Conversation
259b025 to
d0707ca
Compare
- Update all lint-related dependencies. This includes `ember-cli-babel`
and `ember-cli-typescript`, so that we can do the *next* point.
- Use an explicit `babel.config.js` so that @babel/eslint-parser works.
- Add `@babel/preset-env` and `@babel/preset-typescript` as explicit
dependencies and configure them.
- Update how Babel is integrated into the build pipeline.
- Fix the lint errors identified after updates.
d0707ca to
fd04053
Compare
46e80e2 to
fee0b7f
Compare
rwjblue
reviewed
Oct 26, 2021
This was referenced Oct 26, 2021
chriskrycho
added a commit
that referenced
this pull request
Jan 24, 2022
Related to #101 and #102. Bumping to latest Embroider internals exposed some further issue with Babel grabbing the `babel.config.js` used to configure ESLint via `@babel/eslint-parser`. This is a temporary workaround to unblock CI to work more generally, and which is "fine" for now because we don't actually have any unusual syntax in this repo. We will need to do *some* work upstream to finish fixing that more generally for the ecosystem as a whole, though.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ember-cli-babelandember-cli-typescript, so that we can do the next point.@babel/preset-envand@babel/preset-typescriptas explicit dependencies and configure them.