Replace ajax reference to fetch in release guide#742
Replace ajax reference to fetch in release guide#742jenweber merged 2 commits intoember-learn:masterfrom dcyriller:ajax-to-fetch
Conversation
|
As we've been discussing in a few other places (#570 and #708 (comment), switching to @dcyriller any thoughts on how you'd update things here given that constraint? 😉 |
|
There are roughly two options for the guides: either focus on completeness or on fundamentals. We can go deep in the explanations around Ember (including how Ember polyfills for IE11)... Or we can show them how simple ember can be. 😉 It's your call and I'll update the PR if you still want me to. But I wanted to let you know what I think 🙂. Let me know if my word makes you change your mind. |
|
@dcyriller thanks for your work here! The first time ever in the guides that we are advising fetch is now merged, however it uses So many new devs copy & paste our code as it is written, that we want to play it safe. I had no idea myself that fetch was a problem until fairly recently, so I assume that other people may have the same issue. You can link to https://guides.emberjs.com/release/routing/specifying-a-routes-model/#toc_fetch-example if you want to point people towards an explanation of why we are using ember-fetch. Does that sound ok? |
|
P.S. I really like that you have made the prose more generalized. I think it really helps people who are just learning to figure out what is mentioned as examples vs what is a learning requirement. |
|
I've added fetch import in javascript files 👍 |
|
@MelSumner good point, that makes sense. Thanks @dcyriller for your patience and keeping up with comments/edits! Let's merge 🎉 |
This relates to ember-cli/ember-cli#8394