Remove jQuery from app blueprint#8394
Remove jQuery from app blueprint#8394rwjblue merged 3 commits intoember-cli:masterfrom dcyriller:remove-jquery-blueprints
Conversation
|
Oh, I just noticed you already submitted this PR... as I wrote in the issue, I think we have to wait with this until ember-data is ready. See emberjs/ember.js#17476 (comment) |
|
@dcyriller / @simonihmig - ember-data support for working without jQuery landed in 3.9.0, so I think this is ready to start pushing forward again.... |
|
Agree. Ship it! 🎉 |
|
Rebase is done / review is implemented / tests are passing locally. This should be ready 🎉 To be noted: this PR removes ember-ajax from the blueprints (and adds ember-fetch instead). Should the guides / some doc be updated? |
|
|
|
A PR to update the guides is opened here: ember-learn/guides-source#742. But there is still a failing test in CI. I'm not familiar with the concept of smoke test. If anyone could put me in the right direction, I would be grateful 🙏 |
|
Documentation has been merged 🎉 |
|
@dcyriller - Would you mind rebasing? I'd like to get a new CI job kicked off... |
|
done 👍 |
|
@dcyriller Unfortunately this needs another rebase meanwhile! I quickly looked into the failing test, and it seems to be related to this test that needs to be updated: |
This implements the blueprint section of [RFC-0386](https://github.com/emberjs/rfcs/blob/master/text/0386-remove-jquery.md)
|
Thank you! I've updated the test and rebase the branch. |
|
hooray 👏👏👏 |
This implements the blueprint section of
RFC-0386
Relates to this quest emberjs/ember.js#17476