Skip to content

Remove jQuery from app blueprint#8394

Merged
rwjblue merged 3 commits intoember-cli:masterfrom
dcyriller:remove-jquery-blueprints
Aug 1, 2019
Merged

Remove jQuery from app blueprint#8394
rwjblue merged 3 commits intoember-cli:masterfrom
dcyriller:remove-jquery-blueprints

Conversation

@dcyriller
Copy link
Copy Markdown
Contributor

This implements the blueprint section of
RFC-0386

Relates to this quest emberjs/ember.js#17476

@simonihmig
Copy link
Copy Markdown
Contributor

Oh, I just noticed you already submitted this PR... as I wrote in the issue, I think we have to wait with this until ember-data is ready. See emberjs/ember.js#17476 (comment)

@Turbo87 Turbo87 changed the title Remove jQuery from app blueprint WIP: Remove jQuery from app blueprint Feb 6, 2019
@rwjblue
Copy link
Copy Markdown
Member

rwjblue commented Apr 11, 2019

@dcyriller / @simonihmig - ember-data support for working without jQuery landed in 3.9.0, so I think this is ready to start pushing forward again....

@simonihmig
Copy link
Copy Markdown
Contributor

Agree. Ship it! 🎉

@dcyriller
Copy link
Copy Markdown
Contributor Author

Rebase is done / review is implemented / tests are passing locally. This should be ready 🎉

To be noted: this PR removes ember-ajax from the blueprints (and adds ember-fetch instead). Should the guides / some doc be updated?

@rwjblue
Copy link
Copy Markdown
Member

rwjblue commented Apr 12, 2019

Should the guides / some doc be updated?

Yes, we should check in the guides source to confirm that ember-ajax is not mentioned and if it is update it (at least sending a PR)...

/cc @jenweber @locks @mansona

@locks
Copy link
Copy Markdown
Contributor

locks commented Apr 12, 2019

Ember.$.ajax is mentioned at https://guides.emberjs.com/release/configuring-ember/debugging/.
Ember.$getJSON here https://guides.emberjs.com/release/routing/asynchronous-routing/.
$.ajax here https://guides.emberjs.com/release/models/pushing-records-into-the-store/.
I think it's mostly that, but if someone could review the Ember Data chapter, that would be helpful!

@dcyriller
Copy link
Copy Markdown
Contributor Author

A PR to update the guides is opened here: ember-learn/guides-source#742.

But there is still a failing test in CI. I'm not familiar with the concept of smoke test. If anyone could put me in the right direction, I would be grateful 🙏

@dcyriller
Copy link
Copy Markdown
Contributor Author

Documentation has been merged 🎉

@dcyriller dcyriller changed the title WIP: Remove jQuery from app blueprint Remove jQuery from app blueprint May 23, 2019
@rwjblue
Copy link
Copy Markdown
Member

rwjblue commented May 24, 2019

@dcyriller - Would you mind rebasing? I'd like to get a new CI job kicked off...

@dcyriller
Copy link
Copy Markdown
Contributor Author

done 👍

@simonihmig
Copy link
Copy Markdown
Contributor

@dcyriller Unfortunately this needs another rebase meanwhile!

I quickly looked into the failing test, and it seems to be related to this test that needs to be updated:

expected = 'window.EmberENV = {"asdflkmawejf":";jlnu3yr23","_JQUERY_INTEGRATION":true};';

@dcyriller
Copy link
Copy Markdown
Contributor Author

Thank you! I've updated the test and rebase the branch.

@rwjblue rwjblue merged commit 0281c93 into ember-cli:master Aug 1, 2019
@0xadada
Copy link
Copy Markdown

0xadada commented Aug 1, 2019

hooray 👏👏👏

@dcyriller dcyriller deleted the remove-jquery-blueprints branch August 1, 2019 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants