Skip to content

Fix a bug in autofixer and autofix additional cases with firstObject and lastObject in no-get rule#1841

Merged
bmish merged 2 commits intoember-cli:masterfrom
ArtixZ:no-get-firstObject-lastObject
Apr 22, 2023
Merged

Fix a bug in autofixer and autofix additional cases with firstObject and lastObject in no-get rule#1841
bmish merged 2 commits intoember-cli:masterfrom
ArtixZ:no-get-firstObject-lastObject

Conversation

@ArtixZ
Copy link
Copy Markdown
Contributor

@ArtixZ ArtixZ commented Apr 22, 2023

This PR fixes 2 bugs on no-get rule:

@ArtixZ ArtixZ changed the title Bug fixes no-get rule Bug fixes Apr 22, 2023
@ArtixZ ArtixZ changed the title no-get rule Bug fixes no-get rule bug fixes Apr 22, 2023
@bmish bmish added the bug label Apr 22, 2023
@bmish bmish changed the title no-get rule bug fixes Fix a bug in autofixer and autofix additional cases with firstObject and lastObject in no-get` rule Apr 22, 2023
Copy link
Copy Markdown
Member

@bmish bmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@bmish bmish merged commit 7e82eb1 into ember-cli:master Apr 22, 2023
@bmish bmish changed the title Fix a bug in autofixer and autofix additional cases with firstObject and lastObject in no-get` rule Fix a bug in autofixer and autofix additional cases with firstObject and lastObject in no-get rule May 15, 2023
bmish added a commit to bmish/eslint-plugin-ember that referenced this pull request May 21, 2023
* master: (88 commits)
  Release 11.7.0
  build(deps-dev): Bump @typescript-eslint/parser from 5.59.5 to 5.59.6 (ember-cli#1863)
  Account for only having template tag in `no-empty-glimmer-component-classes` rule (ember-cli#1866)
  Support autofix of numerical property access and ternary expressions in `no-get` rule (ember-cli#1865)
  Release 11.6.0
  build(deps-dev): Bump prettier from 2.8.7 to 2.8.8 (ember-cli#1842)
  build(deps-dev): Bump @typescript-eslint/parser from 5.58.0 to 5.59.5 (ember-cli#1860)
  build(deps-dev): Bump @babel/eslint-parser from 7.21.3 to 7.21.8 (ember-cli#1856)
  build(deps-dev): Bump markdownlint-cli from 0.33.0 to 0.34.0 (ember-cli#1848)
  build(deps-dev): Bump jquery from 3.6.4 to 3.7.0 (ember-cli#1861)
  build(deps-dev): Bump release-it from 15.10.1 to 15.10.3 (ember-cli#1859)
  build(deps): Bump vm2 from 3.9.17 to 3.9.18 (ember-cli#1862)
  Support autofix in gts files (ember-cli#1853)
  Only show `no-undef` errors for templates in gts files (ember-cli#1852)
  Release 11.5.2
  Fix a bug in autofixer and autofix additional cases with `firstObject and `lastObject` in `no-get` rule (ember-cli#1841)
  build(deps-dev): Bump eslint from 8.37.0 to 8.38.0 (ember-cli#1830)
  build(deps-dev): Bump @typescript-eslint/parser from 5.57.0 to 5.58.0 (ember-cli#1837)
  build(deps-dev): Bump typescript from 5.0.3 to 5.0.4 (ember-cli#1832)
  build(deps): Bump vm2 from 3.9.11 to 3.9.17 (ember-cli#1839)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update ember/no-get fixer to support firstObject/foo.0.bar scenarios

2 participants