Support Angle Bracket syntax and MU layout#124
Merged
rwjblue merged 4 commits intoember-cli:masterfrom Feb 11, 2019
Merged
Conversation
rwjblue
reviewed
Feb 2, 2019
Member
rwjblue
left a comment
There was a problem hiding this comment.
One minor nit-pick, but changes look good overall.
1b62db3 to
d1bb332
Compare
Contributor
Author
|
@rwjblue Ready for merging now ( I needed some help with ember-cli/ember-compatibility-helpers#32) Next steps after merging:
|
rwjblue
reviewed
Feb 8, 2019
Member
rwjblue
left a comment
There was a problem hiding this comment.
Couple of minor nits, but looks great
Contributor
Author
Member
|
ember-welcome-page 4.0.0 published 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It changes the component copies:
{{welcome-page}}for Ember < 3.4<WelcomePage />for Ember >= 3.4and show the corrent location depending if it is Classic or MU layout.
Discussed at ember-cli/ember-cli#8383, we should also: