Update ember-welcome-page usage to angle brackets#8383
Merged
Conversation
Member
|
Need to update the test fixtures here: |
Contributor
|
fancy |
Contributor
|
The remove the Note: MU apps defines the template at |
Member
|
Great point @ppcano! Mind tweaking the addon to change the copy? With a stretch goal of possibly keeping |
Contributor
|
ember-cli/ember-welcome-page#124 is a PR for the mentioned addon changes |
Member
|
ping @locks - mind updating the fixtures I linked to? |
Contributor
Author
|
On it! |
Contributor
Author
|
Failing test on node 6: 🤔 |
Member
|
ember-cli/ember-welcome-page#124 updates the messaging to use angle bracket invocation as well, it is released in v4.0.0. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.