Failures with imported modifiers and helpers repro#206
Closed
mfeckie wants to merge 7 commits intoember-cli:masterfrom
Closed
Failures with imported modifiers and helpers repro#206mfeckie wants to merge 7 commits intoember-cli:masterfrom
mfeckie wants to merge 7 commits intoember-cli:masterfrom
Conversation
Author
|
Something weird is going on because it's failing when running locally, but not in CI 🤔 (for the repro) 
|
Author
|
Sorry, super weird, definitely failing locally 
|
Contributor
|
I'm seeing the same thing with |
Collaborator
|
I'll investigate momentarily! Apologies for confusion! ember-cli-htmlbars 6.3 as well |
Contributor
|
I'm using |
Collaborator
|
@HeroicEric are you also using embroider? |
Contributor
NullVoxPopuli
added a commit
that referenced
this pull request
Oct 22, 2023
Collaborator
|
more minimal repro here: https://github.com/ember-template-imports/ember-template-imports/pull/211/files#diff-99353e7756ea20bb4fdcc1b1067c0f004b188d13df85162e6ef34b074dd97a2cR26 gonna close this. thanks for the report! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently updated to V4 of ember-template-imports, but have found widespread breakages across our app as a result.
It seems like the template compilation process isn't dealing properly with imported functions and other components, but plain classes seem to be ok.
This PR just adds failing tests to demonstrate the problem, I'm unsure how to fix, but happy to give it some time.
Screenshot from our CI