This repository was archived by the owner on Jun 9, 2020. It is now read-only.
Merged
Conversation
Turbo87
commented
Jan 21, 2018
testem.js
Outdated
| if (process.env['TRAVIS']) { | ||
| // --no-sandbox is needed when running Chrome inside a container | ||
| config.browser_args['Chrome'].args.push('--no-sandbox'); | ||
| } |
Member
Author
There was a problem hiding this comment.
as an alternative we could extract a chromeArgs variable, then the .push() would be a little simpler
This was referenced Mar 20, 2018
ryanlabouve
added a commit
to ryanlabouve/ember-perf
that referenced
this pull request
Apr 17, 2018
Related to travis-ci/travis-ci#8836 Fix copied from to ember-cli/ember-cli-chai#45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses travis-ci/travis-ci#8836 and ember-cli/ember-cli#7472 (comment)