Skip to content

Remove ember-export-application-global addon from app blueprint#9825

Merged
kategengler merged 1 commit intoember-cli:masterfrom
bertdeblock:remove-ember-export-application-global-from-app-blueprint
Apr 14, 2022
Merged

Remove ember-export-application-global addon from app blueprint#9825
kategengler merged 1 commit intoember-cli:masterfrom
bertdeblock:remove-ember-export-application-global-from-app-blueprint

Conversation

@bertdeblock
Copy link
Copy Markdown
Member

@bertdeblock bertdeblock commented Mar 23, 2022

I initially created this RFC issue: emberjs/rfcs#807, but apparently it was
discussed during the CLI meeting that this addon could simply be removed
from the app blueprint. Users can simply install it again if needed.

Related discussion on Discord:
https://discord.com/channels/480462759797063690/480462759797063692/954018119398072320

@rwjblue
Copy link
Copy Markdown
Member

rwjblue commented Apr 11, 2022

Needs a rebase now

@bertdeblock bertdeblock force-pushed the remove-ember-export-application-global-from-app-blueprint branch from 2a10841 to 790c429 Compare April 11, 2022 17:58
@bertdeblock
Copy link
Copy Markdown
Member Author

Done

Windvis added a commit to lblod/frontend-loket that referenced this pull request Apr 14, 2022
This addon isn't used and is going to be removed from the blueprints in the future.

More information: ember-cli/ember-cli#9825
Windvis added a commit to lblod/frontend-loket that referenced this pull request Apr 14, 2022
This addon isn't used and is going to be removed from the blueprints in the future.

More information: ember-cli/ember-cli#9825
@bertdeblock bertdeblock force-pushed the remove-ember-export-application-global-from-app-blueprint branch from 790c429 to f1082ba Compare April 14, 2022 11:25
@locks locks requested a review from kategengler April 14, 2022 12:19
Windvis added a commit to lblod/frontend-loket that referenced this pull request Apr 14, 2022
This addon isn't used and is going to be removed from the blueprints in the future.

More information: ember-cli/ember-cli#9825
@kategengler kategengler merged commit 1915d79 into ember-cli:master Apr 14, 2022
@kategengler
Copy link
Copy Markdown
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants