Skip to content

update dependencies before beta release#9604

Merged
rwjblue merged 9 commits intoember-cli:masterfrom
kellyselden:update_deps
Sep 13, 2021
Merged

update dependencies before beta release#9604
rwjblue merged 9 commits intoember-cli:masterfrom
kellyselden:update_deps

Conversation

@kellyselden
Copy link
Copy Markdown
Member

No description provided.

@kategengler
Copy link
Copy Markdown
Member

I looked into this locally. What it says on the tin, "Error: Could not find module @ember/application/deprecations imported from @ember/string/index", is of course, correct: The included version of @ember/string references @ember/application/deprecations. The @ember/string dependency seems to come from ember-data.
So we need a release of @ember/string and it looks like that will have to be a major bump because of dropping node versions.
and then we'll need a new ember-data beta, updating the dep on @ember/string

@kategengler
Copy link
Copy Markdown
Member

kategengler commented Sep 5, 2021

Updated ember-data with the updated @ember/string. Still failing under Embroider with

Uncaught TypeError: Cannot read property 'String' of undefined at webpack://some-cool-app/../node-bDXlVehj.tmp/node_modules/ember-inflector/make-configurable.js?, line 1

@kategengler
Copy link
Copy Markdown
Member

Looks to be the same errors as in #9597

@kategengler
Copy link
Copy Markdown
Member

Updating embroider seems to have made the build failures multiply.

@kellyselden
Copy link
Copy Markdown
Member Author

OK reverting that last commit

@kategengler kategengler requested a review from rwjblue September 11, 2021 03:53
@rwjblue rwjblue merged commit 39dcf21 into ember-cli:master Sep 13, 2021
@kellyselden kellyselden deleted the update_deps branch November 8, 2021 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants